324960 - css "no-repeat" background image and emoticons not displayed on inlines

Status: RESOLVED FIXED

(Core :: Web Painting, defect, P1)

Description

[Régis Caspar]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060127 Firefox/1.6a1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060127 Firefox/1.6a1

Seems there is a regression from #317375. 
When using css "background" with "no-repeat", image isn't displayed. See testcase.

Reproducible: Always

Steps to Reproduce:
1. open testcase


Actual Results:  
no background image is displayed

Expected Results:  
background image displayed

Comment 1

[Régis Caspar]

Attachment: testcase

Comment 2

[philippe (part-time)]

Attachment: alternative test case

This bug only seems to happen with inline elements.

Attached: same test case as the reporter's, but the <a> element is set to display:block. The background image displays fine.

Comment 3

[Wevah (Nate Weaver)]

I'm seeing this on the Jan 27 Camino and OS X Firefox trunk nightlies.

Hardware/OS -> All/All

Comment 4

[Wevah (Nate Weaver)]

This works properly on the Jan 25 Camino trunk, but not the Jan 26.

Comment 5

[Boris Zbarsky [:bzbarsky]]

The issue is probably the code at http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/layout/base/nsCSSRendering.cpp&rev=3.275&mark=2935,2946-2948#2934 (the highlighted case is the one we fall into).  I should note that this code seems to get positioned inline frames wrong... but the cause for this bug is probably that the coordinate system handling here needs to be fixed.  It looks like we change around the anchor point coords much later in this method, but that's after we've computed all the tiling information, so that's probably wrong.

Comment 6

[Scott MacGregor]

This might also explain Bug #325492.

Comment 7

[Boris Zbarsky [:bzbarsky]]

*** Bug 325492 has been marked as a duplicate of this bug. ***

Comment 8

[Jerry Baker]

Getting emoticons into summary for better search results.

Comment 9

[Jesse Ruderman]

This breaks the "external link" images on MediaWiki pages, which have CSS like

#mBody a[href ^="http://"],
#mBody a[href ^="gopher://"] {
    background: url(external.png) center right no-repeat;
    padding-right: 13px;
}

Comment 10

[philippe (part-time)]

Attachment: testcase using background-repeat:repeat-x

This bug appears not limited to the use of 'no-repeat' for the background property. The test case uses repeat-x as value  for background-repeat value in one case (fails) and omits to specify  this value in the second case (works).

Comment 11

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fun testcases at http://www.hixie.ch/tests/adhoc/css/background/inline/policy/

Comment 12

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 13

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Checked in to trunk.